search

getlift / lift

Expanding Serverless Framework beyond functions using the AWS CDK
MIT License
920 stars 112 forks source link

feat: allow origin fields with cacheBehavior #360

Closed cdominguezg closed 6 months ago

cdominguezg commented 1 year ago

I need to add the origins in order to use API Gateway resources. Tested with extensions but didn't work, so I've implemented another fields to do that.

I've added a new test and also tested in an internal project as a PoC and it works as expected. I updated the docs.

cdominguezg commented 1 year ago

@mnapoli hey! could you take a look on this please?

mnapoli commented 1 year ago

Hi, I'm sorry but I don't think this is something we want to add to Lift. We don't want to add every option available to constructs.

cdominguezg commented 1 year ago

I see, so do you have any recommendation to implement this apart of forking?

mnapoli commented 1 year ago

I would recommend to "eject" from Lift: https://github.com/getlift/lift#ejecting