search

getlift / lift

Expanding Serverless Framework beyond functions using the AWS CDK
MIT License
920 stars 112 forks source link

fix: hide stage in URL in REST scenario #365

Closed jaulz closed 1 year ago

jaulz commented 1 year ago

This PR attempts to solve https://github.com/getlift/lift/issues/364. The issue is that the stage needs to be appended to the URL in REST scenario in order to view the deployed app. By using originPath of the CloudFront distribution we can hide it from the user so he can simply access the CloudFront URL/custom domain.

This is my first time working on a serverless plugin so I hope I used the correct approach. Please me know if I should change anything.

jaulz commented 1 year ago

@mnapoli @fredericbarthelet is there anything I can do to push this forward? 😊

davide-desio-eleva commented 1 year ago

Would love to se this merged!

mnapoli commented 1 year ago

All good thanks!