getlift / lift

Expanding Serverless Framework beyond functions using the AWS CDK
MIT License
920 stars 112 forks source link

Add BlockPublicAccess required config #384

Closed kevincerro closed 5 months ago

kevincerro commented 9 months ago

Fixes #320

Description

Since april 2023, AWS S3 enforces two new default bucket security settings by automatically enabling S3 Block Public Access and disabling S3 access control lists (ACLs) for all new S3 buckets

This hotfix adds missing required BlockPublicAccess configuration.

How to Reproduce

Deploy this stack and error is thrown.

service: demo

provider:
    name: aws
    region: eu-west-3
    stage: prod

plugins:
    - serverless-lift

constructs:
    demo:
        type: static-website
        path: dist

Before

Captura de pantalla 2024-02-20 a las 23 27 10

After

image

richard-stafflink commented 5 months ago

Bonjour @mnapoli, Pourriez-vous Review/Merge s'il vous plaît? Nous en avons besoin.

mnapoli commented 5 months ago

Thank you @kevincerro, awesome job!