search

getlift / lift

Expanding Serverless Framework beyond functions using the AWS CDK
MIT License
920 stars 112 forks source link

Will there be serverless v4 compatibility? #393

Closed cmcnicholas closed 3 months ago

cmcnicholas commented 6 months ago

Start from the Use-case

Serverless v4 is here. https://github.com/serverless/serverless/releases/tag/v4.0.26

Example Config

No response

Implementation Idea

No response

mnapoli commented 6 months ago

Is that incompatible at the moment? Do you get any error?

cmcnicholas commented 6 months ago

Is that incompatible at the moment? Do you get any error?

Just the version dependency currently.

"serverless": "^3.28.0",
mnapoli commented 6 months ago

Understood, we can definitely relax that 👍 Before doing so, it would be great to get confirmation that it works fine :)

austencollins commented 6 months ago

FWIW our intention is to support the Lift plugin in Serverless Framework V.4, as always. We've done some testing recently and discovered a bug. We're working on a fix now and tracking it here: https://github.com/serverless/serverless/issues/12571

rj-xy commented 5 months ago

For anyone looking for a work-around for this, pinning serverless to the latest v3 gets around this issue for the moment, but not ideal.

austencollins commented 5 months ago

Lift should work seamlessly with V.4 now as of this release. We are continuing to test and monitor everything. Please let us know if you see further issues.

dohomi commented 5 months ago

I just started using lift with serverless and struggling with npm dependencies and layers. I use following v4 config:

build:
  esbuild:
    bundle: true
    minify: false
    target: node20
    packages: external

constructs:
  drawing-queue:
    type: queue
    worker:
      handler: src/drawing/worker.handler
      layers:
        - arn:aws:lambda:xxx:layer:chromiumLayer:3
        - arn:aws:lambda:xxx:layer:sharpLayer:2

I bump into the issue that defined layers of construct fields of the yaml not work as expected, also the npm dependencies seem not to work or doesnt seemp to be bundled as the other functions. Am I missing something?

Just to make sure: the dependencies and layers work in the function calls, but I want to make the switch to queue as some tasks are running too long.

Vakintoshka commented 3 months ago

hey guys, any updates on it? it's still impossible to npm install lift with serverless v4

mnapoli commented 3 months ago

https://github.com/serverless/serverless/issues/12571 still mentions issues, can anyone confirm whether Lift works with v4?

Also PRs are welcome.

skierkowski commented 3 months ago

@Vakintoshka Can you elaborate on the install issue you are seeing? If you are seeing the error with a serverless command, can you run serverless support --github and share the output.

skierkowski commented 3 months ago

@mnapoli Hi 👋 , long time! Yes, Serverless Framework v4 works with Lift. I'm confirming this based on analytics and testing. Having said that, there may still be some issues, like the one mentioned in the issue you linked, and the install issue @Vakintoshka mentioned. I'm trying to get the repro steps so we can fix them.

mnapoli commented 3 months ago

Hey @skierkowski! Thanks for the follow-up, I've merged a PR that allows installing lift with v4 👍