Closed nolotz closed 1 month ago
Hi, is this backwards compatible with SF v3?
Hi Antony, its basically the same and end user wouldn't notice.
SF 3.0.0 [1] is using SFU 6.0.0 [2] and since then progress.create
supports message and name properties.
[1] https://github.com/serverless/utils/blob/v6.0.0/docs/log.md [2] https://github.com/serverless/serverless/blob/v3.0.0/package.json
Cheers, Noah
Thanks!
Hi there,
With the release of Serverless 4, it appears that the ServerlessUtils
progress.create()
method now requires an initial argument to be passed. This is causing issues during deployment and any other time theuploadAssets()
function is called.Steps to Reproduce:
uploadAssets
function.progress.create()
.Proposed Fix: Update the
uploadAssets()
function in ServerSideWebsite to pass an initial argument toprogress.create()
as follows:Current Code Reference: https://github.com/getlift/lift/blob/08772c56cc219ca7fa65cc4ff7c4dfea20246a70/src/constructs/aws/ServerSideWebsite.ts#L242
Documentation: https://www.serverless.com/framework/docs/guides/plugins/cli-output#interactive-progress
Solves serverless/serverless#12797
Cheers, Noah