getlogbook / logbook

A cool logging replacement for Python.
http://logbook.readthedocs.org
Other
1.48k stars 165 forks source link

Issue #254 Added more control for rollover naming #255

Closed dusktreader closed 6 years ago

dusktreader commented 6 years ago

In order to match the naming that is used in vanilla logging, I added two additional options to the TimedRotatingFileHandler:

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.1%) to 74.326% when pulling 2743c3d94cb3c9dbae17f2a429608a885f27db36 on dusktreader:ducktreader/254--added-additional-rollover-controls into 0d0d13f5ad6c7295a20a2da41b0c387a9e796bee on getlogbook:develop.

dusktreader commented 6 years ago

@vmalloc Thanks for the input. I've addressed your comment and made one other small change (for clarity). New commit is pushed

vmalloc commented 6 years ago

@dusktreader Thanks for contributing!

dusktreader commented 6 years ago

@vmalloc When do you anticipate your next release will be? (would love to have this feature available from pypi soon)

vmalloc commented 6 years ago

@dusktreader I'll try to release a version relatively soon (hopefully this week). Does the develop branch work well for you so far?

dusktreader commented 6 years ago

@vmalloc I've just been using the latest release from pypi, and I haven't really done a lot of validation because I just finished the conversion from stdlib logging.

If I have some cycles to spare this week, I'll try a dev deployment with the conversion code running against logbook's develop branch and let you know.

Thanks for working on the release! So far logbook has been an absolute pleasure to work with

vmalloc commented 6 years ago

@dusktreader thanks for the kind words!

I released a candidate branch. Assuming all goes well 1.3.0 will be live today with your change! Thanks for your contribution!