Closed dusktreader closed 6 years ago
@vmalloc Thanks for the input. I've addressed your comment and made one other small change (for clarity). New commit is pushed
@dusktreader Thanks for contributing!
@vmalloc When do you anticipate your next release will be? (would love to have this feature available from pypi soon)
@dusktreader I'll try to release a version relatively soon (hopefully this week). Does the develop
branch work well for you so far?
@vmalloc I've just been using the latest release from pypi, and I haven't really done a lot of validation because I just finished the conversion from stdlib logging.
If I have some cycles to spare this week, I'll try a dev deployment with the conversion code running against logbook's develop branch and let you know.
Thanks for working on the release! So far logbook has been an absolute pleasure to work with
@dusktreader thanks for the kind words!
I released a candidate branch. Assuming all goes well 1.3.0 will be live today with your change! Thanks for your contribution!
In order to match the naming that is used in vanilla logging, I added two additional options to the TimedRotatingFileHandler:
rollover_format This allows the user to specify the format that the files should be named with
timed_filename_for_current When set to false, this will direct the handler to use the supplied filename (with no embedded time information) for the current file. Only when the date rolls-over will this be renamed to have a timestamped filename