search

getmango / Mango

Mango is a self-hosted manga server and web reader
https://getmango.app
MIT License
1.69k stars 120 forks source link

Feature/right to left #261

Closed nduja closed 2 years ago

nduja commented 2 years ago

PR for implementing a "Right to Left" viewing mode as per FR #220.

I opted to use ^ this.enableRightToLeft to swap the page direction as it was more concise than wrapping the calls to flipPage() in if/else blocks to populate the right values and putting the logic in flipPage() makes it less obvious when calling.

hkalexling commented 2 years ago

Thanks a lot for the PR! I took a quick look and did notice a small issue - if you check and uncheck the RTL checkbox, and then reload the page, the checkbox would still be checked, even though the page functions as expected. I will investigate when I have more time.

hkalexling commented 2 years ago

LGTM! Thanks guys :heart:

hkalexling commented 2 years ago

@all-contributors Please add @nduja for code

allcontributors[bot] commented 2 years ago

@hkalexling

I've put up a pull request to add @nduja! :tada: