Closed nduja closed 2 years ago
Thanks a lot for the PR! I took a quick look and did notice a small issue - if you check and uncheck the RTL checkbox, and then reload the page, the checkbox would still be checked, even though the page functions as expected. I will investigate when I have more time.
LGTM! Thanks guys :heart:
@all-contributors Please add @nduja for code
@hkalexling
I've put up a pull request to add @nduja! :tada:
PR for implementing a "Right to Left" viewing mode as per FR #220.
I opted to use
^ this.enableRightToLeft
to swap the page direction as it was more concise than wrapping the calls toflipPage()
in if/else blocks to populate the right values and putting the logic inflipPage()
makes it less obvious when calling.