Closed hkalexling closed 2 years ago
It's a very impressive and fantastic feature! It seems you have done really hard work, Thank you.
I really liked the component pattern that applied to subscription-manager
and plugin-download
, it seems toward to a standalone client.
I have read most of codes (except plugin-download
, api
:p I just had a glance at them), and they looks good to me.
Here's some notices.
plugin-download.html
, sorted columns are not preserved though the UI is set to sorted.First, get search result and sort them (I searched New Game!
for example). the table shows well sorted columns started with 1.
After apply filter 'volume = 6' (min 6, max 6), the UI shows that the results are sorted by chapter though they are not actually.
This occurred too when I select another manga at the search result.
I would propose these, too.
Thanks again for your hard work.
@Leeingnyo Thanks for reviewing the PR! These are all good points that can help improve the user experience. I will update the PR.
A new version of the plugin system that supports the following additional features:
mango.settings(key)
. See https://github.com/hkalexling/mango-plugins/wiki/Development-Guideline-v2-(RFC) for details.To target the new v2 API, plugins must put
2
in theapi_version
field in theinfo.json
file. For backward compatability, any plugin without theapi_version
specified will be treated as a v1 plugin.Closes #24. Related https://github.com/hkalexling/mango-plugins/issues/10 and https://github.com/hkalexling/mango-plugins/issues/7.