getmango / Mango

Mango is a self-hosted manga server and web reader
https://getmango.app
MIT License
1.69k stars 120 forks source link

[Bug Report] Error Searching Manga with MangaDex Plugin #290

Closed eroc1990 closed 2 years ago

eroc1990 commented 2 years ago

Describe the bug When searching for manga using the Mangadex plugin, the following error is received:

Search failed. Error: Error: Missing required fields in the Manga type

To Reproduce Steps to reproduce the behavior:

  1. Navigate to Download > Plugins
  2. Select MangaDex from the dropdown
  3. Search for any manga title (sans punctuation, since that also throws an error)

Expected behavior A search result should be returned by the search attempt

Environment (please complete the following information):

Client

Server

Docker (if you are running Mango in a Docker container) version: '2' services: mango: image: hkalexling/mango container_name: "" environment:

Additional context Logged in stdout as well: [91m[ERROR] 2022/04/03 20:05:43 | Missing required fields in the Manga type [91m[ERROR] 2022/04/03 20:05:43 | Missing required fields in the Manga type

hkalexling commented 2 years ago

It works fine for me. Are you using the default settings from the plugin in info.json? Or did you customize any value?

DeepinScreenshot_select-area_20220404101404

eroc1990 commented 2 years ago

The values are the defaults currently in the plugins folder in your repo. Only thing I did was download the plugins with GitZip, unzipped the folder, and uploaded them to the plugins directory on the server I'm hosting it on.

eroc1990 commented 2 years ago

No, I do see what you mean. I guess some titles aren't returning results, and it's throwing that error when nothing's found. I was able to successfully replicate the test you ran in your screenshot.

hkalexling commented 2 years ago

Can you share the query you used? I want to try it myself and maybe make the error message clearer.

eroc1990 commented 2 years ago

Searched the English and Romanji titles of Ijiranaide, Nagatoro-san. That caused the error above to appear.

hkalexling commented 2 years ago

Thanks! It's indeed a bug with the plugin and it has been fixed in https://github.com/hkalexling/mango-plugins/pull/22. Simply updating the plugin should fix it.

eroc1990 commented 2 years ago

Seems we might not be out of the woods yet. The search works fine, but if I choose the first result (the actual manga), I receive a similar error:

Failed to list chapters. Error: Error: Missing required fields in the Chapter type

image

hkalexling commented 2 years ago

Should be fixed by https://github.com/hkalexling/mango-plugins/pull/23 now :)

eroc1990 commented 2 years ago

That did it!