search

getmeli / meli

Platform for deploying static sites and frontend applications easily. Automatic SSL, deploy previews, reverse proxy, and more.
Other
2.4k stars 97 forks source link

Feature-Reqeuest: Add Domain & ENV Bash #210

Closed Berndinox closed 3 years ago

Berndinox commented 3 years ago

I would suggest to add those 2 features:

1) Right now, you can just add an Domain with ACME or with a Custom Certificate. When beeing behind an SSL-Terminating Reverse-Proxy (like in K8s) no Cert is needed at all. How to solve: 3rd Option: Add Domain without Cert image

2) MELI_MONGO_URI should be generated using a bash script inside the container.

In addition we should use the ENV VARs, eg.:

MELI_MONGO_USER MELI_MONGO_PASSWORD MELI_MONGO_HOST MELI_MONGO_PORT MELI_MONGO_DB

The second change is not mandatory, but would make the K8s config easier, also a Secret could be used to inject the Password.

gempain commented 3 years ago
  1. When you set MELI_HTTPS_AUTO, Meli doesn't configure HTTPS at all, even though the UI makes it look like it. This may be confusing. Or are you having an issue getting the site ?
  2. It makes sense. We're so used to only setting the URI that we've never really thought of this.
Berndinox commented 3 years ago

  1. Yes, i have no issue, all working fine. It just was a bit confusing to me. Some Users may not know about the HTTP_Auto "off" thing.

  2. Yeah!, absolutely. Its more of a cosmetic ting. :)

gempain commented 3 years ago
  1. Let's allow both, so everyone is happy.
gempain commented 3 years ago

This will be included in the next release.

I'm closing, but you can keep commenting and we'll reopen if needed.

meli-release-bot commented 3 years ago

:tada: This issue has been resolved in version 1.0.0-beta.22 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: