getmeli / meli

Platform for deploying static sites and frontend applications easily. Automatic SSL, deploy previews, reverse proxy, and more.
Other
2.4k stars 97 forks source link

No organizations visible in Meli #226

Open Runeii opened 3 years ago

Runeii commented 3 years ago

When using Github authentication, Meli does not seem to return/cannot find any organizations attached to my user.

OAuth completes fine and returns me back to Meli without any errors. Also correctly requests permissions for organization: Screenshot 2021-05-06 at 11 52 15

Screenshot 2021-05-06 at 11 52 21

However, when in Meli, the organizations list is empty: Screenshot 2021-05-06 at 11 52 31

Checking Dev Tools and the GET request is completing fine, code 200, but there is an empty response: Screenshot 2021-05-06 at 11 52 44

For reference, I was able to use Meli fine when using standard authentication, but Github integration would be preferable.

gempain commented 3 years ago

Hi there. Each auth method creates new users that aren't initially linked to an organization. To see the organization you initially created with the in-memory auth, you will need to:

  1. connect using the in-memory auth
  2. invite a new user, using which ever email address is necessary
  3. connect to Meli using your Github account
  4. Click the invite link sent to you by email and accept the invite

You MUST be logged in to have access to the actual invitation. We know this is a bit odd, but its due to how our data model works in the background. It's something we have to improve. Was previously mentioned in #224.

Let me know if this helps.

Runeii commented 3 years ago

I think perhaps I'm misunderstanding the organization concept, then – I was under the impression these would match the organizations available in Github? Is that not the case?

gempain commented 3 years ago

No, it is not matching the organization from Github. You have to create an organization in Meli. The only feature Meli has which uses Github orgs is that you can restrict access to users that only belong to specific orgs (so that users from other orgs cannot log into your Meli instance).