search

getmeli / meli

Platform for deploying static sites and frontend applications easily. Automatic SSL, deploy previews, reverse proxy, and more.
Other
2.4k stars 97 forks source link

feat(ui): Improve toast error messages #249

Closed mtiller closed 2 years ago

mtiller commented 2 years ago

This just modified the error handling on several axios calls to extract the underlying error embedded in the HTTP response so it is visible to the user.

Sorry for all the changes. The only real changes here are to the toast calls. It appears that this project doesn't include a .prettierrc file to standardize prettier settings. As s result, you'll end up with this situation where all the files get formatted according to different settings. You might want to consider adding a .prettierrc file to ensure consistent formatting (at least among VS Code users).

This closes #244

gempain commented 2 years ago

Thanks so much for the changes ! Is there a way to rollback the changes made by prettier ? I would happily add a prettier config and also use it across the app, but I'd do this in another MR to avoid mixing things. Would you be able to configure a .prettierrc to automatically rollback the formatting changes ? If it's not possible I'll go through the review but there's indeed quite a lot of changes 😄

mtiller commented 2 years ago

The problem is that I don't know what that .prettierrc should look like. I don't know what settings were used by all the contributors to meli. If we had such a .prettierrc file, all I'd need to do is resave all these files and push one more commit to the end of this branch. Do you know what editor was used for this and what formatting standards were followed?

mtiller commented 2 years ago

I'll resubmit this without all the formatting changes. Just ignore this PR. I'll make a fresh one.

gempain commented 2 years ago

@mtiller don't worry I can still review 😄 Regarding the prettier file to use, all I ask for is:

mtiller commented 2 years ago

There is now a much cleaner PR, #253.