getmetal / motorhead

🧠 Motorhead is a memory and information retrieval server for LLMs.
https://getmetal.io
Apache License 2.0
856 stars 82 forks source link

Sweep (slow): OPENAI_API_BASE is not working #111

Open mckbrchill opened 9 months ago

mckbrchill commented 9 months ago

Details

Bugs: OPENAI_API_BASE env variable is not working, because of the bug in openai-async 0.11.0, and it was fixed in 0.12.2. Features: Refactors: Refactor code accordingly to latest version of openai-async (or at least 0.12.2). The diff between theese two versions also incorporate function calling capabitily, so it affects completion object type.

Checklist - [X] Modify `Cargo.toml` βœ“ https://github.com/getmetal/motorhead/commit/9028d9d5e567e9f221a7825c10c0f9a0c321e033 [Edit](https://github.com/getmetal/motorhead/edit/sweep/openai_api_base_is_not_working/Cargo.toml#L1-L10) - [X] Running GitHub Actions for `Cargo.toml` βœ“ [Edit](https://github.com/getmetal/motorhead/edit/sweep/openai_api_base_is_not_working/Cargo.toml#L1-L10) - [X] Modify `src/models.rs` βœ“ https://github.com/getmetal/motorhead/commit/1f6d9e4592be05d75d05891cf12c632ba2301c9b [Edit](https://github.com/getmetal/motorhead/edit/sweep/openai_api_base_is_not_working/src/models.rs#L57-L75) - [X] Running GitHub Actions for `src/models.rs` βœ“ [Edit](https://github.com/getmetal/motorhead/edit/sweep/openai_api_base_is_not_working/src/models.rs#L57-L75) - [X] Modify `README.md` βœ“ https://github.com/getmetal/motorhead/commit/bdb6ae98a88ea1d0cee9ddd9d01d15c1b86eb29f [Edit](https://github.com/getmetal/motorhead/edit/sweep/openai_api_base_is_not_working/README.md#L98-L100) - [X] Running GitHub Actions for `README.md` βœ“ [Edit](https://github.com/getmetal/motorhead/edit/sweep/openai_api_base_is_not_working/README.md#L98-L100)
sweep-ai[bot] commented 9 months ago

πŸš€ Here's the PR! #112

See Sweep's progress at the progress dashboard!
⚑ Sweep Basic Tier: I'm using GPT-4. You have 5 GPT-4 tickets left for the month and 3 for the day. (tracking ID: 03fcb0c86f)

For more GPT-4 tickets, visit our payment portal. For a one week free trial, try Sweep Pro (unlimited GPT-4 tickets).

[!TIP] I can email you next time I complete a pull request if you set up your email here!


Actions (click)

GitHub Actionsβœ“

Here are the GitHub Actions logs prior to making any changes:

Sandbox logs for 47b6dad
Checking Cargo.toml for syntax errors... βœ… Cargo.toml has no syntax errors! 1/1 βœ“
Checking Cargo.toml for syntax errors...
βœ… Cargo.toml has no syntax errors!

Sandbox passed on the latest main, so sandbox checks will be enabled for this issue.


Step 1: πŸ”Ž Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I think are relevant in decreasing order of relevance (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/getmetal/motorhead/blob/47b6dad303f88f0f196f3b416b6a669fd725e2bd/src/models.rs#L57-L75 https://github.com/getmetal/motorhead/blob/47b6dad303f88f0f196f3b416b6a669fd725e2bd/README.md#L98-L100

Step 2: ⌨️ Coding

--- 
+++ 
@@ -9,7 +9,7 @@

 [dependencies]
 actix-web = "4.3"
-async-openai = "0.11.0"
+async-openai = "0.12.2"
 async-trait = "0.1.68"
 byteorder = "1.4.3"
 chrono = "0.4.24"

Ran GitHub Actions for 9028d9d5e567e9f221a7825c10c0f9a0c321e033:

--- 
+++ 
@@ -59,12 +59,12 @@
                 let openai_api_base = env::var("OPENAI_API_BASE");

                 if let Ok(openai_api_base) = openai_api_base {
-                    let embedding_config = OpenAIConfig::default().with_api_base(&openai_api_base);
-                    let completion_config = OpenAIConfig::default().with_api_base(&openai_api_base);
+                    let embedding_config = OpenAIConfig::new().api_base(&openai_api_base);
+                    let completion_config = OpenAIConfig::new().api_base(&openai_api_base);

                     AnyOpenAIClient::OpenAI {
-                        embedding_client: Client::with_config(embedding_config),
-                        completion_client: Client::with_config(completion_config),
+                        embedding_client: Client::new(&embedding_config),
+                        completion_client: Client::new(&completion_config),
                     }
                 } else {
                     AnyOpenAIClient::OpenAI {

Ran GitHub Actions for 1f6d9e4592be05d75d05891cf12c632ba2301c9b:

--- 
+++ 
@@ -98,7 +98,7 @@
 - `PORT` (default:8000) - Motorhead Server Port
 - `OPENAI_API_KEY`- [Your api key](https://platform.openai.com/account/api-keys) to connect to OpenAI.
 - `REDIS_URL` (required)- URL used to connect to `redis`.
-- `OPENAI_API_BASE` (default:https://api.openai.com/v1) - OpenAI API Base URL
+- `OPENAI_API_BASE` (default:https://api.openai.com/v1) - This environment variable specifies the base URL for the OpenAI API. It's used by the Motorhead server to make API calls to OpenAI for its operations. In most cases, the default value should suffice. However, if you're working with a different OpenAI API endpoint or in an environment where the standard OpenAI endpoints are overridden, you'll need to set this variable accordingly. To set it, use `OPENAI_API_BASE='your_custom_api_base_url'` in your environment configuration.

 ### Azure deployment

Ran GitHub Actions for bdb6ae98a88ea1d0cee9ddd9d01d15c1b86eb29f:


Step 3: πŸ” Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/openai_api_base_is_not_working.


πŸŽ‰ Latest improvements to Sweep:
  • New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
  • Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
  • Use the GitHub issues extension for creating Sweep issues directly from your editor.

πŸ’‘ To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request.Something wrong? Let us know.

This is an automated message generated by Sweep AI.