getminera / minera

Minera is a web interface to monitor and manage mining devices
http://getminera.com
Other
374 stars 156 forks source link

Awesome font icon fix #164

Closed ghost closed 7 years ago

ghost commented 7 years ago

Please add the following to fix the awesome fonts they are broke. minera/views/include/header.php:

michelem09 commented 7 years ago

Your message was truncated

ghost commented 7 years ago

Here is the diff fix on paste bin. https://pastebin.com/StQgc9RL

Im switched to the testing version and let you know what i find. I will setup a virtualbox fresh 16.04 install and let you know.

michelem09 commented 7 years ago

Why do you declare it twice?

ghost commented 7 years ago

Because I like to do things twice, The cdn can bounce. In my code I replaced it with cloudflare. I declare it twice because sometimes cdn have anti-spam detection that fubars stuff up and one will fail. I would recommend not to use the cdn for just the css and 4 font files and just dump them on the local system

ghost commented 7 years ago

Here's why cloudflare and all the cdns anti dos causes the script to randomly fail.

On Thu, Aug 17, 2017 at 6:33 AM, Michele Marcucci notifications@github.com wrote:

Why do you declare it twice?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/michelem09/minera/issues/164#issuecomment-322981512, or mute the thread https://github.com/notifications/unsubscribe-auth/AWn0w06iADydrWH6uqgjR4rS3RyllfOWks5sY96fgaJpZM4O5qvs .

ghost commented 7 years ago

Dump the files with wget and declare them once

On Thu, Aug 17, 2017 at 7:08 AM, Jason Kurtz tekcommnv@gmail.com wrote:

Here's why cloudflare and all the cdns anti dos causes the script to randomly fail.

On Thu, Aug 17, 2017 at 6:33 AM, Michele Marcucci < notifications@github.com> wrote:

Why do you declare it twice?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/michelem09/minera/issues/164#issuecomment-322981512, or mute the thread https://github.com/notifications/unsubscribe-auth/AWn0w06iADydrWH6uqgjR4rS3RyllfOWks5sY96fgaJpZM4O5qvs .

michelem09 commented 7 years ago

Yes probably it's the best solution keeping it local, I will work on this.

michelem09 commented 7 years ago

Changed to local fonts ready for next release