Closed BjornSAIM closed 1 month ago
A couple of quick comments:
But it is such a great idea, thank you so much!
A couple of quick comments:
- Could you add a test (only for JSON, there is no need to copy + paste it into all the formats)?
- Could you also add some documentation on how to use your class? (If it's too much of a hassle, I can do it as well, no problem).
- Very minor thing: In this library, we generally use CamelCase for types and classes...so could you rename "refl_type" into something like "ReflType"?
check, check and check
@BjornSAIM , this looks great.
If the tests run through fine, I will merge it. I'm actually currently on a train and have almost reached my location, so I won't be able to merge it right now. But it will find some time some time today.
Thank you so much for your contribution!
@BjornSAIM and @DaedieCool , sorry, I had a very busy weekend so I didn't get to merging this until now. But, again, thank you so much for this great addition to the library.
see: https://github.com/getml/reflect-cpp/issues/141