identifiers that begin with an underscore and followed by an uppercase letter should not be used

getml / reflect-cpp

A C++20 library for fast serialization, deserialization and validation using reflection. Supports JSON, BSON, CBOR, flexbuffers, msgpack, TOML, XML, YAML / msgpack.org[C++20]

https://getml.github.io/reflect-cpp/

MIT License

901 stars 76 forks source link

identifiers that begin with an underscore and followed by an uppercase letter should not be used #9

Closed travnick closed 9 months ago

travnick commented 10 months ago

https://github.com/getml/reflect-cpp/blob/a0d6aa1b0564d186bcc4ad48e753c7ba5676ac61/include/rfl/Field.hpp#L17 Identifiers like _Type should not be used since it may trigger any magic behaviour. n4868

(3.1) Each identifier that contains a double underscore __ or begins with an underscore followed by an
uppercase letter is reserved to the implementation for any use

liuzicheng1987 commented 10 months ago

Good point. I‘ll fix it.

liuzicheng1987 commented 9 months ago

Fixed. Thanks for the issue. Great input.