Timestream Write has the wrong response returned

[shogarth-cog]

Environment

Python 3.10.2 (and 3.9 in lambda)

Libraries involved installed from pip: boto3 1.20.49 botocore 1.23.49 moto 3.1.0 pytest 7.1.0 pytest-mock 3.7.0

Expectation for response

The AWS documentation for timestream-write.client.write_records states that the response should be a dictionary of the form:

{
    'RecordsIngested': {
        'Total': 123,
        'MemoryStore': 123,
        'MagneticStore': 123
    }
}

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/timestream-write.html#TimestreamWrite.Client.write_records

Actual response

Printing the response results in:

{'ResponseMetadata': {'HTTPStatusCode': 200, 'HTTPHeaders': {'server': 'amazon.com'}, 'RetryAttempts': 0}}

Testcase

import boto3
import os
import pytest

from my_thing.main import MyClass
from moto import mock_timestreamwrite

@pytest.fixture
def aws_credentials():
    """Mocked AWS Credentials for moto."""
    os.environ["AWS_ACCESS_KEY_ID"] = "testing"
    os.environ["AWS_SECRET_ACCESS_KEY"] = "testing"
    os.environ["AWS_SECURITY_TOKEN"] = "testing"
    os.environ["AWS_SESSION_TOKEN"] = "testing"
    os.environ["AWS_DEFAULT_REGION"] = "us-east-1"
    yield

@pytest.fixture
def ts_client(aws_credentials):
    with mock_timestreamwrite():
        conn = boto3.client("timestream-write")
        yield conn

@pytest.fixture
def create_ts_table(ts_client):
    ts_client.create_database(DatabaseName='ts_test_db')
    ts_client.create_table(DatabaseName='ts_test_db', TableName='ts_test_table')
    yield

def test_ts_write(ts_client, create_ts_table):
    my_object = MyClass()
    event = {} # appropriate dict here
    result = my_object.ts_write(event, 'ts_test_db', 'ts_test_table')
    assert result is True

def ts_write(self, event: dict, ts_db_name: str, ts_table_name: str) -> bool:
        ts_client = boto3.client("timestream-write")
        response = ts_client.write_records(
                DatabaseName = ts_db_name,
                TableName=ts_table_name,
                Records=[
                    {
                        "Dimensions": [
                            {"Name": "Account_Id", "Value": event["Payload"]["detail"]["Account_id"]},
                            {"Name": "Type", "Value": event["Payload"]["detail-type"]},
                        ],
                        "MeasureName": event["Payload"]["detail"]["measure_name"],
                        "MeasureValue": str(event["Payload"]["detail"]["measure_value"]),
                        "MeasureValueType": "DOUBLE",
                        "Time": str(event["Timestamp"]),
                        "TimeUnit": "SECONDS"
                    }])

        if response["RecordsIngested"]["Total"] > 0:
            self.logger.info("Wrote event to timestream records")
            return True
        else:
            self.logger.error("Failed to write to timestream records")
            return False

This then fails in the testing with an KeyError instead of matching the expectation set by the AWS spec.

[bblommers]

Thanks for raising this @jhogarth - marking it as an enhancement.