getmoto / moto

A library that allows you to easily mock out tests based on AWS infrastructure.
http://docs.getmoto.org/en/latest/
Apache License 2.0
7.66k stars 2.05k forks source link

[BUG Fix] route53 - list_tags_for_resources: Resolve when a single ID is provided #8143

Closed zkarpinski closed 1 month ago

zkarpinski commented 1 month ago

Fixes two bugs.

  1. When list_tags_for_resource is passed only a single ID, the request is a string and not a list
  2. The regex for deriving resource_type was always None
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.50%. Comparing base (d8da0ac) to head (8045221). Report is 5 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8143 +/- ## ======================================= Coverage 94.50% 94.50% ======================================= Files 1150 1150 Lines 99191 99193 +2 ======================================= + Hits 93736 93738 +2 Misses 5455 5455 ``` | [Flag](https://app.codecov.io/gh/getmoto/moto/pull/8143/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto) | Coverage Δ | | |---|---|---| | [servertests](https://app.codecov.io/gh/getmoto/moto/pull/8143/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto) | `28.78% <0.00%> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/getmoto/moto/pull/8143/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto) | `94.47% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zkarpinski commented 1 month ago

@bblommers Another bug fix for the route53 endpoint that slipped through :(