getmoto / moto

A library that allows you to easily mock out tests based on AWS infrastructure.
http://docs.getmoto.org/en/latest/
Apache License 2.0
7.66k stars 2.05k forks source link

[BUG FIX] Firehose - Snowflake destination: Fix `put_record` and `put_record_batch` functions #8152

Closed sp-bdanies closed 1 month ago

sp-bdanies commented 1 month ago

Hello, based on my last PR (https://github.com/getmoto/moto/pull/8122), I completely forgot to add the modifications for the put_record_batch function.

I'm sorry, here is the FIX :) :)

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.50%. Comparing base (6c68326) to head (0769c5c). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8152 +/- ## ======================================= Coverage 94.50% 94.50% ======================================= Files 1150 1150 Lines 99203 99203 ======================================= Hits 93752 93752 Misses 5451 5451 ``` | [Flag](https://app.codecov.io/gh/getmoto/moto/pull/8152/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto) | Coverage Δ | | |---|---|---| | [servertests](https://app.codecov.io/gh/getmoto/moto/pull/8152/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto) | `28.79% <0.00%> (ø)` | | | [unittests](https://app.codecov.io/gh/getmoto/moto/pull/8152/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto) | `94.47% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.