getmoto / moto

A library that allows you to easily mock out tests based on AWS infrastructure.
http://docs.getmoto.org/en/latest/
Apache License 2.0
7.66k stars 2.05k forks source link

Fix Cloudformation ECS task definition memory validation #8170

Closed jmsanders closed 1 month ago

jmsanders commented 1 month ago

Very similar to: https://github.com/getmoto/moto/pull/7280

But for cases when register task definition is being called via cloudformation.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.51%. Comparing base (6c68326) to head (38d8d05). Report is 12 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8170 +/- ## ======================================= Coverage 94.50% 94.51% ======================================= Files 1150 1150 Lines 99203 99187 -16 ======================================= - Hits 93752 93746 -6 + Misses 5451 5441 -10 ``` | [Flag](https://app.codecov.io/gh/getmoto/moto/pull/8170/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto) | Coverage Δ | | |---|---|---| | [servertests](https://app.codecov.io/gh/getmoto/moto/pull/8170/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto) | `28.78% <0.00%> (-0.02%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/getmoto/moto/pull/8170/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto) | `94.48% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.