getmoto / moto

A library that allows you to easily mock out tests based on AWS infrastructure.
http://docs.getmoto.org/en/latest/
Apache License 2.0
7.66k stars 2.05k forks source link

EC2: create_network_acl_entry() now supports the Ipv6CidrBlock-parameter #8173

Closed bblommers closed 1 month ago

bblommers commented 1 month ago

With this parameter now returning correctly, terraform no longer feels the need to recreate NetworkACL entries every time.

And because of that, we can run the same test steps (apply / plan / delete) for all terraform tests, including EC2.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.52%. Comparing base (6c68326) to head (47530b5). Report is 14 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8173 +/- ## ========================================== + Coverage 94.50% 94.52% +0.01% ========================================== Files 1150 1150 Lines 99203 99359 +156 ========================================== + Hits 93752 93915 +163 + Misses 5451 5444 -7 ``` | [Flag](https://app.codecov.io/gh/getmoto/moto/pull/8173/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto) | Coverage Δ | | |---|---|---| | [servertests](https://app.codecov.io/gh/getmoto/moto/pull/8173/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto) | `28.76% <33.33%> (-0.04%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/getmoto/moto/pull/8173/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto) | `94.49% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.