codecov[bot]
commented
1 month ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.54%. Comparing base (
d0affa8) to head (57c12b8). Report is 3 commits behind head on master.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #8230 +/- ## ======================================= Coverage 94.54% 94.54% ======================================= Files 1158 1158 Lines 100093 100096 +3 ======================================= + Hits 94633 94636 +3 Misses 5460 5460 ``` | [Flag](https://app.codecov.io/gh/getmoto/moto/pull/8230/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto) | Coverage Δ | | |---|---|---| | [servertests](https://app.codecov.io/gh/getmoto/moto/pull/8230/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto) | `28.88% <66.66%> (+<0.01%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/getmoto/moto/pull/8230/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto) | `94.51% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Motivation
As a follow up to #8216, This pr aims at expanding support of custom ids to resources that can be created with tags. Providing a tag named
_custom_idsat creation can be used to create a custom id for the created resource.Changes
get_id_from_tagsmethod to by able to accept tags created as dict (e.g{"_custom_id_": "myCustomId"}) or as a list (e.g.[ {"Key": "_custom_id_", "Value": "myCustomId"} ])TODO