getmoto / moto

A library that allows you to easily mock out tests based on AWS infrastructure.
http://docs.getmoto.org/en/latest/
Apache License 2.0
7.66k stars 2.05k forks source link

MemoryDB: create_cluster() ensure TLSEnabled can be False #8240

Closed archinksagar closed 3 weeks ago

archinksagar commented 4 weeks ago

The response for 'TLSEnabled' and 'AutoMinorVersionUpgrade' is always True even when they are set to False. This PR fixes this issue.

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.54%. Comparing base (77fbf51) to head (95d95c7). Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
moto/memorydb/models.py 70.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8240 +/- ## ========================================== - Coverage 94.54% 94.54% -0.01% ========================================== Files 1158 1158 Lines 100124 100131 +7 ========================================== + Hits 94667 94671 +4 - Misses 5457 5460 +3 ``` | [Flag](https://app.codecov.io/gh/getmoto/moto/pull/8240/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto) | Coverage Δ | | |---|---|---| | [servertests](https://app.codecov.io/gh/getmoto/moto/pull/8240/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto) | `28.87% <0.00%> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/getmoto/moto/pull/8240/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto) | `94.51% <70.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getmoto#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.