search

getmoto / py-partiql-parser

Python Parser for PartiQL
MIT License
7 stars 2 forks source link

/tests/ shouldn't be explicitly listed in dependencies #8

Closed fstrzalka closed 1 year ago

fstrzalka commented 1 year ago

https://github.com/getmoto/py-partiql-parser/commit/b2e88929ff68878229f0c6981fea7ef721456d8f

This is an antipattern and actually causes errors when importing packages that are using Your package by downloading from github - as (on the other hand) a very common pattern is to use \tests\ as an internal module in many python projects. Are You sure this is even necessary?

bblommers commented 1 year ago

Hi @fstrzalka, it sounds like you and #9 have the same problem. In short: No, this is not necessary - we'll switch to using MANIFEST.in in the next release.

bblommers commented 1 year ago

OK, this should be fixed with 0.3.7. The wheel only has the source files, the sdist has both source and test.

Thanks for raising this @fstrzalka - just let us know if you run into any other issues.