Signup via facebook - Githubissues

begedin commented 8 years ago

Closes #54, #6, #47, #7

TODO:

[x] Allow creating the user with the facebook access token and facebook id parameters provided
[x] Allow later singing in using those parameters
[x] Take user's profile picture from facebook?
[x] Automatically follow all the user's friends in the app.

begedin commented 8 years ago

Some notes

I extracted all the facebook stuff that made sense into a FacebookService object app-side, as well as into a FacebookHelper module spec-side.
Only our FacebookService spec uses VCR. Allow of our other specs simply mock the service
Unlike our usual apps, I decided to go with one worker which we use to update the user's photo in various ways. If the worker grows to be too complex, we can split it up using performer/scenario objects. I feel this makes more sense, since the worker is technically doing a single job. It only differs by how it does it.
User following is done mostly the same as in our other projects. We have a UserRelationship model with a follower and a following. The user has helper methods follow(other_user), unfollow(other_user) and following?(other_user)
Special: As part of this PR, I also added the option to provide a photo during normal user registration. It's a minor change, so I felt it's easier to just add it here rather than create a whole new PR, especially considering the refactoring done in this one. The commit log was edited in such a way that the change will be visible.

begedin commented 8 years ago

I cleaned this up a bit so we don't have to rely on prepend. I'm also still looking into proper facebook authentication.

I found this and it seems like a pretty clean way to do it. However, while refactoring this, a few things occurred to me.

When registering through facebook, either email and password should not be required as parameters, or password should not be required and email should be pulled from facebook using Koala.
User should be able to set their email/password at a later time (this is how it usually works with facebook authentication)
Right now, when signing in, we just check if the user with the specified facebook id and access token is in our database. We may want to consider checking with facebook first if it's a valid token/id combination at all. The assumption is that it will be, but still.

For this purpose, I've created the issue #62 to handle this separately. I think this is mergeable as is, for now.

joshsmith commented 8 years ago

With that minor change, this is good to go.

getmovement / deprecated-movement-rails-api