Add campaings, campaign_volunteers

getmovement / deprecated-movement-rails-api

DEPRECATED Rails API for getmovement.org

1 stars 1 forks source link

Add campaings, campaign_volunteers #57

Closed begedin closed 8 years ago

begedin commented 8 years ago

Will be part of closing #9

Questions

Is the user a volunteer, or is there a special volunteer relation which is associated with the user?
Should joining a campaign as a volunteer require approval by someone
Do campaigns have owners as of this moment? The way I understood in our conversations, we would initially have "pre-set" campaigns.
I'll add more if I think of any...

joshsmith commented 8 years ago

I think it's simplest to have the User as a volunteer.

I don't think a volunteer requires approval.

I think campaigns can have owners but not necessarily a requirement. Maybe we own campaigns that are not claimed? Not sure the best way to handle that. But yes, the idea is that campaigns can "claim" their campaign.

joshsmith commented 8 years ago

Should we be adding campaigns to a User as well? I.e. you want to see the campaigns you joined.

begedin commented 8 years ago

@JoshSmith I've added a has_many for campaigns and campaign_volunteerships to the user model as well, so this is ready for review again.

joshsmith commented 8 years ago

There are some minor changes to be made here, though nothing involving much discussion to my mind. Feel free to merge without review after changes.