getmovement / deprecated-movement-rails-api

DEPRECATED Rails API for getmovement.org
1 stars 1 forks source link

Very basic address API, with all the required infrastructure ready #59

Closed begedin closed 8 years ago

begedin commented 8 years ago

This is a very basic Address API infrastructure, which we can then expand with its proper features as we are merging other branches in. It's the first step to close #14, but far from enough to actually do it.

I believe this is ready for review and merge as is, but we can discuss additional requirements (for other PRs) in the issue thread in #14.

christopherstyles commented 8 years ago

Looks great, works great! 👍

joshsmith commented 8 years ago

@begedin I have a number of questions here before we can merge this.

begedin commented 8 years ago

Marked this as awaiting review again. I renamed state_codeto state_abbreviation, because I've seen that name for the column in other places, including, I believe, a voter file.