search

getnamo / 7zip-cpp

Fork of SevenZip++ for modern builds.
Other
224 stars 94 forks source link

Created a base class for all archives that share members where appropriate #14

Closed keithjjones closed 8 years ago

keithjjones commented 8 years ago

@getnamo I don't have a good test for compression yet, but I think 9d215ac works. The only part that may not work is the constructor when I fill in the values for the protected members. If I messed that up, please feel free to change it.

keithjjones commented 8 years ago

Hopefully those changes will make it better. We now have one class representing an archive file and different uses for archive files (extracting, compressing, listing,etc...) can inherit that base class (SevenZipArchive).

getnamo commented 8 years ago

That's a good change, merged and I will work in the compression callbacks (https://github.com/getnamo/7zip-cpp/tree/ue4) from the ue4 branch in a few days. Managed to confirm all required functionality (there are some kinks to compression to keep in mind) and made the first public pass at the ue4 wrapper, found here: https://github.com/getnamo/ZipUtility-ue4