getnamo / 7zip-cpp

Fork of SevenZip++ for modern builds.
Other
221 stars 93 forks source link

Fix file-rename operations and Allow format detection to fail #24

Closed error454 closed 6 years ago

error454 commented 6 years ago

Finally got the 7zpp-TestApp running and noticed that extraction test 4 was failing. My fault, I was stripping the path seperation character as part of the invalid character check. Fixed that.

I noticed that DetectCompressionFormat always returns true, even if the format is undetected at the end, yet there are many places in the UE4 plugin that assume a false state. It now returns false if no format could be detected.

getnamo commented 6 years ago

Great catches, merged :)