getnamo / NodeJs-Unreal

Embed node.js as an Unreal Engine plugin.
MIT License
242 stars 36 forks source link

Packaging Support #6

Closed getnamo closed 4 years ago

getnamo commented 5 years ago

Will likely need to add scripts folder to packaging like https://github.com/getnamo/tensorflow-ue4/blob/master/Source/TensorFlow/TensorFlow.Build.cs#L28

meignotn commented 4 years ago

any ETA on this issues ? i tried to copy manualy the script folder into the package but it crashes

helghast commented 4 years ago

any ETA on this issues ? i tried to copy manualy the script folder into the package but it crashes

I have the same problem. Look at my message in the main thread: https://forums.unrealengine.com/community/work-in-progress/1644397-node-js

getnamo commented 4 years ago

I'll likely look into this issue sometime in January at earliest. In meantime the path is currently defined here: https://github.com/getnamo/nodejs-ue4/blob/master/Source/CommandLine/Private/NodeCmd.cpp#L40 changing this to reflect the location of the embedded ThirdParty/node content should suffice to make the plugin work in a packaged build (after copying third party folder over to that location after packaging)

NB: A proper fix would be to add a step in https://github.com/getnamo/nodejs-ue4/blob/master/Source/CommandLine/CommandLine.Build.cs to auto-copy the third party directory when packaging.

qduborper commented 4 years ago

Hello! thanks for the quickfix. The game now starts but not the server instance. Do I need also to copy the Scripts folder to content ?

thanks

getnamo commented 4 years ago

That sounds right. You should have both the third party folder and the scripts folder in the same relative folders as the project in the packaged folder for it to find everything

getnamo commented 4 years ago

Support added in https://github.com/getnamo/nodejs-ue4/commit/7fad399b536995b194e307285351541417790b2f. Will land as the v0.5 release

Instructions for packaging are found here: https://github.com/getnamo/nodejs-ue4#packaging

getnamo commented 4 years ago

Closing with release: https://github.com/getnamo/nodejs-ue4/releases/tag/0.5.0, open new issue if new packaging issues appear