search

getnamo / UDP-Unreal

Convenience UDP wrapper for the Unreal Engine.
MIT License
335 stars 79 forks source link

Fixed invalid IPAdress.h include path #41

Closed jfmilke closed 6 months ago

jfmilke commented 7 months ago

Fixes Isse #39 where Unreal would not build with the current include path for IPAddress.h.

getnamo commented 6 months ago

Which unreal engine version expected that format?

jfmilke commented 6 months ago

For me it's at least UE 5.3, but I didn't test whether it occours earlier.

getnamo commented 6 months ago

And which platform? I'll merge this after testing it compiles as expected on Windows

brifsttar commented 6 months ago

Just an FYI: I started migrating to 5.4, and this change is needed for it, otherwise plugin doesn't build (Windows).

jfmilke commented 6 months ago

Sorry for the late reply, I encountered myself the problem on UE 5.3 (specifically 5.3.2).

Bertrand Richard @.***> schrieb am Mi., 24. Apr. 2024, 14:03:

Just an FYI: I started migrating to 5.4, and this change is needed for it, otherwise plugin doesn't build (Windows).

— Reply to this email directly, view it on GitHub https://github.com/getnamo/UDP-Unreal/pull/41#issuecomment-2074783430, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKIXUR4XJLSSV2NNMSC4JZDY66NPRAVCNFSM6AAAAABFUVW7YCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZUG44DGNBTGA . You are receiving this because you authored the thread.Message ID: @.***>

jfmilke commented 6 months ago

Also, it was necessary on Windows 10 (x64) for me.

Jan Frieder Milke @.***> schrieb am Mi., 24. Apr. 2024, 14:40:

Sorry for the late reply, I encountered myself the problem on UE 5.3 (specifically 5.3.2).

Bertrand Richard @.***> schrieb am Mi., 24. Apr. 2024, 14:03:

Just an FYI: I started migrating to 5.4, and this change is needed for it, otherwise plugin doesn't build (Windows).

— Reply to this email directly, view it on GitHub https://github.com/getnamo/UDP-Unreal/pull/41#issuecomment-2074783430, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKIXUR4XJLSSV2NNMSC4JZDY66NPRAVCNFSM6AAAAABFUVW7YCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZUG44DGNBTGA . You are receiving this because you authored the thread.Message ID: @.***>

getnamo commented 6 months ago

Merged, thanks for spotting and confirming