Updated with last fixes and additions from 20tab master

getnamo / UnrealEnginePython

Embed Python in Unreal Engine 4

MIT License

59 stars 16 forks source link

Updated with last fixes and additions from 20tab master #10

Closed ghost closed 5 years ago

ghost commented 5 years ago

I hope I've caught all your changes. My tests were all successful at least.

getnamo commented 5 years ago

Compiles and runs correctly from a clean slate? (site packages deleted -> re-downloading dependencies)

ghost commented 5 years ago

I just did the following test again:

Get a fresh local clone from my fork
Create a new basic C++ UE 4.20.3 project
Copy the clone into the Plugin folder of the project
Extract the Binaries folder from your latest release v1.6.0 into the clone folder
Startup UE with the project
Open Python Console and type print(sys.version) which results in 3.6.4 (v3.6.4:d48eceb, Dec 19 2017, 06:54:40) [MSC v.1900 64 bit (AMD64)]

So my informed but still wary answer would be: yes. Sideeffects etc. are still possible of course. I'll also test it again with a fresh tensorflow-ue project for an additional lifelike test.

ghost commented 5 years ago

Just testet again, this time with an empty Blueprint project, first copying your latest tensorflow-ue plugin folder into it, then overwriting all files in UEP with my fork files, extract your TF-Examples release and start the project. The Basic example runs like it should. So I guess everything went well enough.

getnamo commented 5 years ago

Sounds good, merging.

getnamo commented 5 years ago

Made a small mistake with this merge. In my fork, this function https://github.com/getnamo/UnrealEnginePython/blob/5bb20bf1b650606ccac7e6dd9ff2abfe8e299763/Source/UnrealEnginePython/Private/UEPyEngine.cpp#L724 needs to use custom logic to allow data passing on gamethread.

Made the revert here: https://github.com/getnamo/UnrealEnginePython/commit/bc382d468a9d3123efdffb8695182c8276a6eb2f