getndazn / kopytko-framework

A modern Roku's Brightscript framework based on JS world's solutions
MIT License
19 stars 6 forks source link

fix: active route should skip is omitted in history #24

Closed bchelkowski closed 2 years ago

bchelkowski commented 2 years ago

What did you implement:

Fixes problem where the active route is not skipped in the history when field shouldSkip is true.

How can we verify it:

  1. Add should skip to some route.
  2. During the journey, go to that route.
  3. From that route navigate to the next route.
  4. Press the back button (should trigger router.back()).
  5. Navigation should not bring you to the previous route.

Todos:

Is this ready for review?: YES Is it a breaking change?: NO

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.0.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: