getndazn / kopytko-framework

A modern Roku's Brightscript framework based on JS world's solutions
MIT License
19 stars 6 forks source link

HttpResponse to expose the response headers #25

Closed aquanaut closed 2 years ago

aquanaut commented 2 years ago

This is a Feature Proposal

Description

What is the use case that should be solved. The more detail you describe this in the easier it is to understand for us.

HTTP responses' headers often contain useful info, eg: response caching rules. I propose that HttpResponse exposes the response headers.

If there is additional config how would it look?

N/A

Similar or dependent issues:

N/A

aquanaut commented 2 years ago

I would like to work upon this issue, please, as Tomasz showed me the fix 😄

bchelkowski commented 2 years ago

Sure, there is already a private field with headers in the HttpResponse. So probably you just need to set this field in the node returned in method toNode().

It will be good also to add this in the test for HttpResponse. But this is something I can follow after.

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 1.0.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: