fix: validating parent when removing children from Kopytko component - Githubissues

getndazn / kopytko-framework

A modern Roku's Brightscript framework based on JS world's solutions

MIT License

19 stars 6 forks source link

fix: validating parent when removing children from Kopytko component #29

Closed RadoslawZambrowski closed 2 years ago

RadoslawZambrowski commented 2 years ago

What did you implement:

Fixed a crash when the component was removed from the view when removing children elements was not finished.

How did you implement it:

Added validation if parent of an element to remove is not invalid

How can we verify it:

Trigger component destroy and remove the parent from the view (e.g. trigger it from the main thread).

Todos:

[X] Write documentation (if required)
[X] Fix linting errors
[X] Enable "Allow edits from maintainers" for this PR
[X] Update the messages below

Is this ready for review?: YES Is it a breaking change?: NO

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: