search

getndazn / kopytko-framework

A modern Roku's Brightscript framework based on JS world's solutions
MIT License
19 stars 6 forks source link

fix: Ignoring Invalid elements when calculating elements' index in children array #31

Closed pawelhertman closed 2 years ago

pawelhertman commented 2 years ago

What did you implement:

Fixed incorrect children insertion if children array contains Invalid elements

How did you implement it:

By differently comparing current and new children arrays

How can we verify it:

Unit tests

Todos:

Is this ready for review?: YES Is it a breaking change?: NO

pawelhertman commented 2 years ago

I suggest reviewing commit by commit because I changed the order of private methods and Github's preview looks crazy

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.3.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: