feat: enhanced destroyKopytkoRoot to call destroyKopytko - Githubissues

getndazn / kopytko-framework

A modern Roku's Brightscript framework based on JS world's solutions

MIT License

19 stars 6 forks source link

feat: enhanced destroyKopytkoRoot to call destroyKopytko #34

Closed RadoslawZambrowski closed 2 years ago

RadoslawZambrowski commented 2 years ago

What did you implement:

Follow-up after https://github.com/getndazn/kopytko-framework/pull/32

Calling destroyKopytko from destroyKopytkoRoot so there is no need to call one after another.

How did you implement it:

Calling destroyKopytko at the end of destroyKopytkoRoot.

How can we verify it:

Todos:

[X] Write documentation (if required)
[X] Fix linting errors
[X] Enable "Allow edits from maintainers" for this PR
[X] Update the messages below

Is this ready for review?: YES Is it a breaking change?: NO

tomek-r commented 2 years ago

Hey @RadoslawZambrowski https://github.com/getndazn/kopytko-framework/blob/master/docs/renderer.md#initkopytkoroot-method it would be nice to add destroyKopytkoRoot doc.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: