There is an issue with the renderer that removes the component from its parent when the child of the component has the same id and has been conditionally removed.
How did you implement it:
To fix the issue a map of the rendered elements was introduced and instead of using the native findNode function the map is checked for the existence of the element.
findNode includes also the component on which we call it, not only children of it:
Returns the node that is a descendant of the nearest component ancestor of the subject node (possibly the subject node itself) and whose id field is set to name.
How can we verify it:
All should work as before (no regression), but additionally, it should be possible to have the same id for the parent and child components.
What did you implement:
There is an issue with the renderer that removes the component from its parent when the child of the component has the same
id
and has been conditionally removed.How did you implement it:
To fix the issue a map of the rendered elements was introduced and instead of using the native
findNode
function the map is checked for the existence of the element.findNode
includes also the component on which we call it, not only children of it:From the docs:
How can we verify it:
All should work as before (no regression), but additionally, it should be possible to have the same id for the parent and child components.
E.g Template 1:
Template 2 of
Component1
:Todos:
Is this ready for review?: YES Is it a breaking change?: NO