getndazn / kopytko-framework

A modern Roku's Brightscript framework based on JS world's solutions
MIT License
19 stars 6 forks source link

fix: attaching observer in kopytkoRoot #52

Closed RadoslawZambrowski closed 10 months ago

RadoslawZambrowski commented 10 months ago

What did you implement:

initKopytkoRoot function attaches observers for dynamic props before calling initKopytko, thus it is possible that field change callback kopytkoRoot_dynamicPropChanged is called before initialization is completed. And this is because initKopytko updates the component with provided dynamic props by calling m.top.update(dynamicProps)

How did you implement it:

Moved attaching observers after the initKopytko call

How can we verify it:

Todos:

Is this ready for review?: YES Is it a breaking change?: NO

github-actions[bot] commented 10 months ago

:tada: This PR is included in version 2.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: