search

getndazn / kopytko-utils

A collection of modern utility functions for Brightscript applications
MIT License
6 stars 4 forks source link

feat: Added support to missing Animation node fields #17

Closed RadoslawZambrowski closed 1 year ago

RadoslawZambrowski commented 1 year ago

What did you implement:

It's not possible to set some of the Animation node fields through the AnimatorFactory. I've added missing fields.

How did you implement it:

Reading missing fields from the options parameter.

How can we verify it:

Todos:

Is this ready for review?: YES Is it a breaking change?: NO

RadoslawZambrowski commented 1 year ago

Don't we have any unit tests for this entity?

We have and they were updated: https://github.com/getndazn/kopytko-utils/pull/17/files#diff-8a21e16d3a7e666a5d34482ad3d79b2b2fc85b8f528d3c44622cc76d9f0e2e4d

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: