getndazn / kopytko-utils

A collection of modern utility functions for Brightscript applications
MIT License
6 stars 4 forks source link

fix: Handling non-string parameters by buildUrl #23

Closed RadoslawZambrowski closed 9 months ago

RadoslawZambrowski commented 9 months ago

What did you implement:

Currently, passing a non-string parameter crashes the app. Changed buildUrl function to accept non-string parameters that can be converted to a string, e.g. boolean, int, etc.

How did you implement it:

Checking if the parameter implements ifToStr interface. If it does, then the value is converted and used, otherwise a warning is printed in the telnet

How can we verify it:

Todos:

Is this ready for review?: YES Is it a breaking change?: NO

github-actions[bot] commented 9 months ago

:tada: This PR is included in version 2.4.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: