Closed cheshirekow closed 6 years ago
:+1: from me, please try cleaning it up. But perhaps (2) would work better if you used the bootstrap-style expanding menu, if that’s possible?
Cool. Have any pointers to documentation/tutorial/example of the bootstrap-style expanding menu you're referring to? Also is there a nikola style guide or should I just try to match what's there?
I mean the menu bootstrap3
uses. There is no style guide for CSS — be reasonable, avoid unreadably clever hacks, indent with 4 spaces.
Updated the review.
Excuse my ignorance, I'm still not 100% positive what you meant by the menu, but I think I implemented it. As implemented, it looks like this:
unexpanded:
expanded:
I meant a menu that behaves the same way https://getnikola.com/ does on mobile. The hamburger button would work better as part of the green header.
Ok done. Moved hamburger button into the header. Now looks like this:
Closed:
Open:
Looks great, thanks for fixing this!
In the smallest of the bootstrap breakpoints:
The comments probably aren't desirable and I didn't even check on style issues... but if the change is desirable I'd be happy to clean up this patch.