search

getnikola / nikola-themes

Themes for Nikola
https://themes.getnikola.com/
71 stars 51 forks source link

Some preview images are not representative of the theme #140

Closed tritium21 closed 6 years ago

tritium21 commented 6 years ago

The preview image below is rendered incorrectly, compared to how it actually renders.

bnw

This is how it renders in Firefox (probably correct.)

firefox_2018-01-11_05-38-22

ralsina commented 6 years ago

Well, that depends on what fonts you have in the system, doesn't it?

Kwpolska commented 6 years ago

This is caused by PhantomJS being terribly outdated. We could fix it with headless Chrome and Puppeteer for example.

tritium21 commented 6 years ago

I was more concerned with phantomjs apparently choosing to render text in arbitrarily wrong locations

Kwpolska commented 6 years ago

Well, that’s what I’m talking about: PhantomJS’s engine is outdated and isn’t as good at new CSS tricks as Chrome/Firefox. Font faces chosen is irrelevant.

Kwpolska commented 6 years ago

Fixed in commit be97dd1 by using Puppeteer. Needs one-time config and a Chrome/ium install, comes with much more accurate screenshots.