search

getnikola / nikola-themes

Themes for Nikola
https://themes.getnikola.com/
71 stars 51 forks source link

[zen] Usage of ForkAwesome icon fonts instead of FontAwesome #151

Closed encarsia closed 6 years ago

encarsia commented 6 years ago

I modified the zen theme to use icons from the ForkAwesome project instead of the originally used FontAwesome icons which is in active development and contains more icons.

Currently FontAwesome v.3.2.1 is still used which has been deprecated for a while now.

Kwpolska commented 6 years ago

What's wrong with Font Awesome 5? (Also, any changes need to be migrated to zen-jinja.)

-- Chris Warrick https://chriswarrick.com/

On Tue, Apr 24, 2018, 11:33 encarsia notifications@github.com wrote:

I modified the zen theme to use icons from the ForkAwesome https://forkawesome.github.io project instead of the originally used FontAwesome http://fontawesome.io icons which is in active development and contains more icons.

Currently FontAwesome v.3.2.1 is still used which has been deprecated for a while now.

You can view, comment on, or merge this pull request online at:

https://github.com/getnikola/nikola-themes/pull/151 Commit Summary

  • [zen] use ForkAwesome font icons instead of FontAwesome
  • my bad

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/getnikola/nikola-themes/pull/151, or mute the thread https://github.com/notifications/unsubscribe-auth/AAT-m8w8Vx-F3b_Cwy7sLPVV-x0oyu64ks5trvEhgaJpZM4ThUsm .

encarsia commented 6 years ago

What's wrong with Font Awesome 5?

Nothing, I guess. But Fork Awesome has Mastodon and other FLOSS related icons Font Awesome hasn't.

Also, any changes need to be migrated to zen-jinja.

Done.

Regards Anke

ralsina commented 6 years ago

Why not make it a separate theme instead?

Inherit zen, then change only the parts that need changing.

encarsia commented 6 years ago

That would be fine for me, too.

So I basically revert changes I made in the existing themes and create a new one based on zen.

Kwpolska commented 6 years ago

zen could be upgraded to fontawesome v4. A v5 upgrade could also be done, but that one requires updating font references (eg. fab fa-twitter because Twitter is now in the “brand” icon set)

ralsina commented 6 years ago

+1 to making a zen fork and to upgrading zen to FA v4 (but not really important)

encarsia commented 6 years ago

zen could be upgraded to fontawesome v4

Since ForkAwesome is a FA 4.7 fork and going with FA 4.7 on my personal site this is doable. It appears logical to start with this task first before creating the zen fork to achieve my initial request.