search

getnikola / nikola-themes

Themes for Nikola
https://themes.getnikola.com/
71 stars 51 forks source link

[zen] again: Font Awesome update to v4.7.0 + theme fork with Fork Awesome v1.0.11 #152

Closed encarsia closed 6 years ago

encarsia commented 6 years ago

Hey all,

as proposed in #151 I updated the zen family to FA4 (de9189c5cbd40d5aba1d4b865beaf2dba24bf504) and created a variant (zen-forkawesome) that uses Fork Awesome icon fonts (24339193fa8ae0e243601422df9286b7090b52d2).

Before messing things up I decided to accomplish that in a new branch so my last PR was closed when deleting the former working branch.

encarsia commented 6 years ago

Comprehension question before I mess things up: if the theme generally loads FA from CDN the USE_CDN variable in conf.py will not have any effect, will it? (because otherwise the files/cruft had to be provided)

Kwpolska commented 6 years ago

Yes, ignore USE_CDN and always use one.

encarsia commented 6 years ago

Changes:

  1. added "fa" prefix to conf.py.sample files as requested
  2. Fork Awesome also loaded via CDN
  3. the Fork Awesome variant now uses main.css of parent theme (zen)

From my perspective I'm done now...(?)

Kwpolska commented 6 years ago

Merged, thanks!

On a side note, the zen theme needs some modernizations to be usable with v8. I’ll work on it (and other themes) on Saturday.

Kwpolska commented 6 years ago

I upgraded zen to v8 and Font Awesome v5. zen-forkawesome still works (although needs a few more overrides).