search

getnikola / nikola-themes

Themes for Nikola
https://themes.getnikola.com/
71 stars 51 forks source link

[hyde theme] Source code line numbers broken #154

Closed hartwork closed 6 years ago

hartwork commented 6 years ago

Related to #153. Source code rendering, especially the line numbers are way off with the (otherwise very appealing) hyde theme. This is recent Firefox, same in recent Chromium:

nikola__hyde_theme__source_code

ralsina commented 6 years ago

The problem is that those are getting white-space: pre-wrap instead of pre so it's probably an easy fix. Looking...

ralsina commented 6 years ago

One line fix in def205216aab57754e0c25af05e47558ccc95680

hartwork commented 6 years ago

Awesome!

Now that the most off thing is fixed, i notice how the source code listing is has horizontal space at places where it doesnot add to beauty but makes the listing a lot wider than the rest of the article. I'm not suggesting to make it too short, but maybe reduce whitespace a bit and even widen the page to get them back together? Here's a picture:

nikola__hyde_theme__source_code_2

Happy to make a new ticket instead, as needed.

ralsina commented 6 years ago

Sure, why not.