search

getnikola / nikola-themes

Themes for Nikola
https://themes.getnikola.com/
71 stars 51 forks source link

[hyde theme] Source code listing has suboptimal spacing #155

Closed hartwork closed 6 years ago

hartwork commented 6 years ago

Hi!

This started os as a comment at https://github.com/getnikola/nikola-themes/issues/154#issuecomment-390284849 but here it goes as a dedicated ticket again:

Now that line number are back in line, I notice how the source code listing has horizontal space at places where it does not add to beauty but makes the listing a lot wider than the rest of the article. I'm not suggesting to make it too narrow, but maybe reduce whitespace a bit and even widen the page to get them back together? Here's a picture:

40250110-921248ee-5ad5-11e8-905e-5b7aa9aaa697

Thanks in advance!

ralsina commented 6 years ago

Fixed (or at least improved) I think in 93bae0293fdb77c90114198d39b5549a9f412db7

hartwork commented 6 years ago

Hi @ralsina,

while I was very looking forward to see this in action, the numbered listing has improved a lot but unfortunately there is a regression on code listings without numbers now: No-numbers listings had some margin/padding left and right for a centered look previously, but the left one is gone now which looks kind of broken:

nikola_hyde_regression

Would be cool to have the changes only affect numbered listings again. Thanks!

ralsina commented 6 years ago

There is no way to do that AFAICS.

hartwork commented 6 years ago

Let me propose a deal: Let's revert the previous commit, re-open the bug and I try to make a pull request making both work based on your prior work. What do you think?

ralsina commented 6 years ago

I like it better now than before. If you want to propose a different change, please do a PR.