search

getnikola / nikola-themes

Themes for Nikola
https://themes.getnikola.com/
71 stars 51 forks source link

[hyde theme] Re-center listings without line numbers (fixes #155 regression) #157

Closed hartwork closed 6 years ago

hartwork commented 6 years ago

@ralsina what do you think?

Original (before 93bae0293fdb77c90114198d39b5549a9f412db7)

hyde_original

Broken status quo

hyde_before

With pull request applied

hyde_after

Kwpolska commented 6 years ago

Why not make these code blocks full-width?

hartwork commented 6 years ago

It does not look cool, at least not with this very theme, it fits other themes better. If it was made full width, it would need other adjustments as well, probably a different background color, adjusted padding, maybe a single-pixel border or so. I'd rather not go there, it was beautiful until recently.

hartwork commented 6 years ago

This is what listings without numbers looked like until a day ago, prior to 93bae0293fdb77c90114198d39b5549a9f412db7. This is about repair.

Kwpolska commented 6 years ago

Okay, but let’s make it look better and make both code blocks look the same way.

hartwork commented 6 years ago

That's a new pull request in my eyes. Let's fix the regression first, please.

hartwork commented 6 years ago

Please please :smiley:

Kwpolska commented 6 years ago

No, please do it the right way in this PR.

hartwork commented 6 years ago

I disagree about what you call the right way and we have two distinct topics here. If this is a power game, I'm out.