search

getnikola / nikola-themes

Themes for Nikola
https://themes.getnikola.com/
71 stars 51 forks source link

[hyde theme] Unbreak code listing #159

Closed hartwork closed 6 years ago

hartwork commented 6 years ago

Click the thumbnails for life size versions. Please consider for application.

Prior to 93bae0293fdb77c90114198d39b5549a9f412db7 — current — with pull request

0_initial_w150 1_current_w150 2_after_w150

Thank, Sebastian

Kwpolska commented 6 years ago

I’m merging this, but IMO it would still be nice to have consistency between both styles of blocks, so perhaps you could create a PR for that as well?

hartwork commented 6 years ago

Thank you!

I find the no-numbers version more friendly and use it in my blog, exclusively. Those two being different can be seen as a feature: Authors get to choose between a light, friendly version without line numbers for shorter things, fewer distractions, and a serious version with full width, a frame and numbers that you can refer to in the text after. Why take that choice away?

Kwpolska commented 6 years ago

Because if you do have the “choice”, you might end up having both styles in one post, which looks inconsistent. If someone wants the lighter style, they could modify CSS to their will.