search

getnikola / nikola-themes

Themes for Nikola
https://themes.getnikola.com/
70 stars 51 forks source link

nikola theme luna #176

Closed Henry-Jia closed 4 years ago

Kwpolska commented 4 years ago

You should also include the license for the original Moon theme, and mention it in based_on in the .theme file. We also recommend a lowercase name for the directory and luna.theme file.

-- Chris Warrick https://chriswarrick.com/

On Mon, 2 Sep 2019, 13:36 Roberto Alsina, notifications@github.com wrote:

@ralsina requested changes on this pull request.

Hi! First of all: Thanks for your contribution!

BUT: you are including massive 3rd party assets, you should add license information for each, at least. Alternatively, load them from a CDN?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/getnikola/nikola-themes/pull/176?email_source=notifications&email_token=AACP5GYASPUF5JTSYVGP323QHT3CLA5CNFSM4IS4QCV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDLVCOY#pullrequestreview-282546491, or mute the thread https://github.com/notifications/unsubscribe-auth/AACP5G6V43SAFRJG5VGLKI3QHT3CLANCNFSM4IS4QCVQ .